- This topic has 12 replies, 2 voices, and was last updated 3 years, 2 months ago by
.
-
Posts
-
Hi,
Can you fix these errors quickly please?
W3C validation error : Element “div” not allowed as child of element “button” in this context.
<button class='promagnifier' aria-label="Bouton loupe de recherche"> <span class='asp_text_button hiddend'> Recherche </span> <span class='innericon'> </span> <div class="asp_clear"></div> </button>Validation RGAA : Improper Use of Link. (link without href attribute).
<a class='asp_showmore'>Voir tous les résultats <span></span></a>Hi,
Thanks for the report, we will look into these for the upcoming release, luckily these are super minor issues. I have added them to the issue tracker. Thank you again!
Hi,
Thank you for your prompt response.
These 2 problems are the only ones that prevent us from being W3C and RGAA valid.
Our client with standardization and web accessibility objectives.
It is not minor for us as for them.
Technically, however, this should be easily corrected by your teams.For information, the site is officially presented tomorrow 🙂
If you want, I can fix it for you directly on site, these should be super easy to fix. In that case all I need is temporary FTP access, and I will change the corresponding files. Let me know 🙂
Hi,
I can’t give you these accesses, but I’m a web developer.
tell me the code of the modifications that will not affect the functioning of your plugin and I will put them in place while waiting for the publication of your update.Have a nice day
Sure, no problem!
We are about to release a secutiry patch, I have made the modifications to it. I am attaching that version here, please install and test. It should address both of these reported issues.
Hi,
Thanks for this release.
it’s ok for W3C validation, but not in RGAA.I see the href value of the #asp_showmore anchor, but it doesn’t refer to any ID.
Personally the action at the link returns to the native WP search result page /?s=&asp_active=1&p_asid=2&p_asp_data=1&Another solution is to relaunch the link with a button.
Does RGAA have any recommendations for links handled by javascript event handlers?
This tag is only used to display the “show more” text, and “href” attribute value does not matter. I mean I can change it to maybe link to the home page, if that becomes seemingly valid, but it will not change it’s behaviour whatsoever.From what I understand, the recommendation will be not to use a link but a button: https://equalizedigital.com/accessibility-checker/improper-use-of-link/
Yes, that sounds about right. Unfortunately I would like to avoid that, as it would require a lot of styling and script changes and potential issues with API. I have attached another possible version, please let me know if this one is okay for the validator.
Hi,
Yes, I understand the technical consequences and the need for backwards compatibility.
It passes RGAA validation!
Thank you very much, for your intervention.Best wishes
You are welcome, thank you for the feedback 🙂 I will leave it like this then for a while, then probably figure out something for a next major release.
If you don’t mind, I will close this topic soon and mark it as resolved, feel free to open another one if you have other questions or issues.
If you like the plugin and have not rated already, feel free to leave a rating on your codecanyon downloads page and on the wordpress plugin repository, it’s greatly appreciated.
- The topic ‘Validation W3C + RGAA’ is closed to new replies.