Thanks for the details, I see what the problem is now.
So looking at the search.php file in your theme directory, there is the problem. The override works, the results are passed to the results page, instead of printing the results there is a code looking for a specific template page (page id = 1751). I've looked up that page and that has a shortcode, which is then executed and its content is then printed. However that shortcode uses it's own method (executed long after the override) to get the results, it does not get the ones that are already overridden, and that is later printed to the results page by your custom code.Best,
If you like my products, don't forget to rate them on codecanyon :)