Hi Ernest,
There’s no need to apologize for the concise responses. I actually appreciate your efficiency and don’t mind short answers so long as they fully address the issues (which these did). With that said I will do my best to keep my answers concise as well. I know I tend to be very descriptive in my writing (I have a detail-oriented nature).
I have to say how appreciative I am of you providing these custom filters for me. I realize these can be used for other customers of yours, but you are basically providing me with custom programming. I pay a lot of money here for programmers, so having your help with things like this saves me a lot of time and money. It’s also much more efficient as you know your plugin extremely well, and are fast with writing functions like this. We’ve written a number of custom functions for ASP as well, but you are much better at it because of your familiarity with the plugin. With that said, my continued thanks!
ITEM 1
Indeed, and I think it’s because of the index table. I have made a change to the code, so now it recognizes the attachments and corrects this mistake.
Your corrections for this problem worked perfectly. The attachment results are now displaying the proper custom title. Thanks!
ITEM 2
In this case, that could be possible. There is also another change in the code above, so that when you se the $separate_taxonomies variable to true, then the taxonomy names will be used in the title instead.
This too is working very nicely for separating the taxonomy term titles. There is only one remaining issue:
We use the term “Subcategories” instead of “Tags,” and right now this is displaying the word Tags. Can you add two fill-in-the-blank options to the filter so that when this option is enabled we can specify the names for the categories and tags taxonomies? It is displaying the correct word for categories by the way, but I figured we should include options for both taxonomy names.
Related Question:
At some point in the future would it be possible to separate the actual filter option for taxonomies, so users can filter by categories and tags separately in the search settings? Right now it is a combined option. It would be very helpful to have these separated in the filters if its technically possible.
ITEM 3
This took me a while to check. There is a buddypress function for that, I have made a change to the code to include that as well.
Just letting you know that this worked perfectly, and the BuddyPress last active option is now displaying the proper BuddyPress time format. Sorry this took you a lot of time to figure out. I could have told you there was a custom function for that.
ITEMS 4 & 5
Yep, the comment content type filter is indeed missing as it seems. I will make sure to include it in the upcoming release, that should resolve this completely.
I’ve been thinking more about this and I believe it would be best to include the comments content type as a possible content type filter in the search settings. The filter should have the ability to be custom named like the other filter options do (we call comments “contributions” on our platform). The reason I think you should add this is there is an inherent difference between saying “search in comments” and “filter out comments.” It makes sense that if you don’t search in comments that comment type results should not display. However, it is still not a filter, and since comments are a content type it should be filterable.
ITEM 6
This is perfectly fine, I have included in the changed file as well.
Thanks for the confirmation. I have actually added similar css classes to the custom fields filter as well.
ITEM 7
Thank you for letting me know. I will have to cross-check this as well, and make sure to include the options missing in the next release.
These are just missing label options, for Filter by Format and Filter by Categories in the search settings. Thanks for adding them to the next release!
…..
And this is what I call concise answers… 😉
I am really looking forward to showing you our implementation of ASP. I think it will be the most fully customized implementation you’ve ever seen. Choosing your plugin was one of the best decisions I made for our platform! 🙂
~ Michael