we added a test page with just the short code to eliminate any variable issues due to the search being in the modal.
https://devsfk.wpengine.com/test-2/?preview_id=84218&preview_nonce=0bf5d7b8e8&preview=true
further testing finds that there is an issue with Premium Addons for Elementor (we have the pro version but it breaks with just the free version too). If we disable this plugin the no results page works correct but we have many elementor elements from this plugin all over the site.