Forum Replies Created
-
AuthorPosts
-
dokMixer
ParticipantHi Ernest, and thanks for your insights !
Yeah, i kinda figured out when debugging the issue, that wordpress loads his own Jquery (except in child themes, where you have to add some code apparently), and reading here and there that you should use this version when developping plugins for wordpress. For simplicity, scope issues, loading times, … and mostly because it’s already bundled in WordPress. And modifying wordpress when using one plugin is not something you can tell your clients.
So yeah, i did change a lot of things, including moving the calls in the functions.php (enqueuing), uing jQuery(something) instead of $(something) etc etc.
I dont see any performance change, but the problems have disappeared. And… i even fixed an issue with a call i made in photon where i was trying to reset the facebook call for sharing an article, and got errors in the console even if the share worked fine. So i guess i even fixed that too.
I had issues with linkedin, though, and had to replace the share button. But meh, i’m fine with it.I only have ONE issue now, which is not causing me any trouble i guess, but prints an error in the console. After a couple clics i got this ‘KeyboardEvent.keyIdentifier’ is deprecated and will be removed in M53…
but i THINK it’s because i use Vivaldi and got an update yesterday. Just wanted to let you know, cause maybe some calls to your functions use this, and might get obsolete with the next chrome version (vivaldi uses chromium).Thanks again for the long answer and your enlightments, they really helped !
Best regards,
MatdokMixer
ParticipantHm, i tried to put the latest Jquery and it didnt fix the izimodal behavior. I guess it’s more an issue of the modals themselves, with the enqueues.
dokMixer
ParticipantOkay, still got some conflicts here.
http://anewmars.com/00_dev/ellipse-avocats.com/cabinet/aix/I know it’s a bit out of the scope of your plugin, but since it’s induced by it…
Try on the right hand sign to use the contact button : the overlay shows up, but the modal comes way after.
I suspect the Jquery version, since it was working flawlessly just before.
When enqueing the script, maybe i have to change the dependencies, or i don’t know, use a more recent version of jquery, still compatible with your plugin ?Using this atm :
[code]wp_register_script(‘iziModal’, get_template_directory_uri().’/js/iziModal.min.js’, array(‘jquery’),”, false);[/code]Got any idea ?
dokMixer
ParticipantHi Ernest.
I had to dig up and force myself to use the enqueue script stuff in the wordpress functions.
I didnt want to in the first place, because ‘photon’ had to be loaded before the document completion in some cases. Nevermind.FYI i enqued everything, have the JQMIGRATE text showing in console, and cannot override wordpress basic jquery with a more recent one. I wanted to integrate jquery v3+, but your plugin isn’t compatible (some ‘on’ and ‘load’ are no more written the same way. No big deal, but you should consider looking into that 🙂 ). So yeah, i had to use the native jquery, and downgrade some stuff in my scripts to get everything working as expected or almost as expected.
Good news is… i am fully operational again, the previous scripts are almost 100% functional, and the search is fully working.
Now to stylize it !quick notes :
– the scrolling behaviour in the dynamic search is buggy under OSX
– i have not found yet a way to stylize the scrollbar. Still looking. If it’s not available, make it so please ! 😀
– I will also add some CSS styling to this. Not sure yet where to put that, will look into it soon too.Thanks for your time, very appreciated !
Best regards,
MatdokMixer
ParticipantHi and thanks for your fast answer Ernest.
The velocity error disappears when the plugin is disabled. Everything is working fine without the plugin. The plugin introduces something in the loading of the different javascript scripts.
Velocity is a great library for animating : it’s way faster than jquery. And in this case, i am using it to animate big chunks of the site.I have not loaded the scripts inside wordpress with a clean declaration (i beleive i should enqueue them somewhere ?) and am writing them directly in the header with a file_get_content (this, to be sure scripts are loaded in a particular order). I don’t have a big experience with plugins creation and wanted to stay ‘independant’ from wordpress by doing so. Maybe it’s the reason i have this issue now ?
I cannot give you FTP access sadly, but if we have no choice i will try to create a limited FTP access later. It’s just time consuming with our process.
Here is the site we are working on : http://anewmars.com/00_dev/ellipse-avocats.com/
I left the plugin activated, so you can see the error popping.Is there anything i can do to try to debug this ?
Mat
dokMixer
ParticipantAnother view of where the bug happens with my scripts.
-
AuthorPosts