Plugin Customasation

[book24sa]

Good day
Kindly assist with a plugin customisation.

[Ernest Marcinko]

Hi,

Please note that plugin customization is not part of the support process (Support Policy). If you need some basic changes, let me know as detailed as possible, I might be able to help.

For more complex customizations, I recommend the following service: wpkraken.io

[book24sa]

You cannot access this content.

[Ernest Marcinko]

Hi,

The problem was because there is something going wrong with the minification process, I had to turn it off: https://i.imgur.com/2LdIXwv.png

The localization of the main script was not executed correctly after the minification, so the script variables were unset. I will investigate this issue on my local environment, and contact the w3tc plugin developers if neccessary.

[book24sa]

You cannot access this content.

[book24sa]

You cannot access this content.

[Ernest Marcinko]

Hi,

Yes, I did investigate this further, but the issue is not within the search apparently, nor within the core W3TC plugin.

I see you have a custom made W3TC plugin as well, which I guess takes the localized inline script and puts it within a custom function. That is not correct, as it moves it out of the window scope and the ASP variable gets undefined.

If you are the one who made that, then make sure that the:

[php]wp_localize_script(‘wd-asp-ajaxsearchpro’, ‘ASP’, array(…[/php]

and the

[php]wp_localize_script(‘wd-asp-ajaxsearchpro’, ‘ajaxsearchpro’, array(..[/php]

..localizations are not moved away from the window scope. This is not possible to fix from this plugins perspective, as wp_localize_script is a core wordpress function, which places an inline script just before the handler, which is executed in the window scope. If the output is moved to a custom javascript function, it will not work.

[book24sa]

You cannot access this content.

[Ernest Marcinko]

Hi,

The issue still the minification unfortunately. I cannot re-create the issue with the core W3TC plugin, as it works correctly – I use it on the demo site as well, it is great.

However as I mentioned earlier, the two very important global variables are moved by the minification script to the site footer, into a custom function. Please take a look at this, this is from your site footer: https://i.imgur.com/WNUNR95.png
These variables have to be outside of any function, and currently they are encapsuled within the window.w3tc_run_foot() function, which is causing the problem, as the ASP and the ajaxsearchpro variables become local and no longer accessible outside the function, as they should be.

This is not caused by the search plugin, it is very likely a customization, the code originally works fine as well as with the original W3TC minification script. There is nothing I can do about this, as it is caused by customization, which moves the search variables to a function scope, making them local, which is incorrect. Localized variables should not be removed from the window’s scope.

[Author]

Posts